[ADE-66] update report processing logic to handle isMedicalReport correctly and improve error handling #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly and improve error handling
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the report processing logic to ensure that non‐medical reports are handled correctly and improves error handling in both frontend and backend.
- Updated the error handling flow in the frontend by reordering conditions and adding an early return on failed reports.
- Modified the backend logic for the isMedicalReport field to return undefined instead of false when the value is falsy.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/pages/Processing/ProcessingPage.tsx | Refactored condition checks in the error handling branch for processing reports. |
| backend/src/reports/reports.service.ts | Adjusted the isMedicalReport field value to return undefined instead of false in certain cases. |
GuidoBR
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
update report processing logic to handle isMedicalReport correctly and improve error handling
Does this PR introduce a breaking change?
{...}
What needs to be documented once your changes are merged?
{...}
Additional Comments
{...}